Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not fail vmtool.cmd if buildertype is vsphere using Packer 1.5.2+ #234

Merged
merged 1 commit into from
Feb 28, 2020

Conversation

daxgames
Copy link
Contributor

@daxgames daxgames commented Feb 26, 2020

No description provided.

@arizvisa
Copy link
Contributor

Nice. That's awesome that Packer split up the conditionals from the vmware-* builders into the vsphere-* builders while I was gone. Hashicorp is awesome.

@arizvisa arizvisa merged commit 3723854 into boxcutter:master Feb 28, 2020
@arizvisa arizvisa self-requested a review February 28, 2020 22:31
@arizvisa arizvisa added bug A bug in the way that a template is built or provisioned enhancement This will introduce or improve an already existing capability labels Feb 28, 2020
@daxgames
Copy link
Contributor Author

Vsphere-iso and vsphere-clone are two completely new builders that interface with esxi using the vspere api. Originally written by Jetbrains and merged into Packer master as on 1.5.2.

The original vmware builders are still there and do the same as what they used to do for local vmware workstation and esxi builds using ssh to a apecific host.

The vsphere builders are really nice and work well.

@arizvisa
Copy link
Contributor

Ah, was thinking it was related to hashicorp/packer#7212.

There were a number of conditionals in the vmware builders that allowed esx to be split up into two distinctly different builders. Regardless, glad that vsphere builders are separate from the vmware builders instead of it being a number of conditionals that were hacked into the vmware builders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug in the way that a template is built or provisioned enhancement This will introduce or improve an already existing capability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants